[YUNIKORN-1875] Support for Compressed Encoded configMap BinaryData, gzip compression support #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gzip support A config map on K8s can only be 1MB. Thus a larger config map could be sent by compressing, encoding, and storing in configMap.BinaryData. This commit makes Yunikorn support gzip compressed 64bit encoded BinaryData.
wilfred-s
requested changes
Sep 15, 2023
Import ordering changes, error handling and logging for gzipReader close, added testcases for decompress.
Shadow declaration of err variable removed.
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
- Coverage 71.92% 71.83% -0.10%
==========================================
Files 51 51
Lines 8082 8116 +34
==========================================
+ Hits 5813 5830 +17
- Misses 2073 2086 +13
- Partials 196 200 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
waiting for the build to finish before committing |
1 task
|
@sidbroski hi, I come from #752 It seems this feature encounters the base64 decoding error. Just curious, have you launched this function in your machine? If so, please share the k8s version or env to us. I want to avoid the compatibility issue if #752 removes the explicit decoding from yunikorn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
A config map on K8s can only be 1MB. Thus a larger config map could be sent by compressing, encoding, and storing in configMap.BinaryData.
This commit makes Yunikorn support gzip compressed 64bit encoded BinaryData.
What type of PR is it?
Todos
What is the Jira issue?
YUNIKORN-1875
How should this be tested?
Screenshots (if appropriate)
Questions: